Adding optional columns before compute with columns. #2445
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the preprocessing step of portfolio columns before using the columns. This PR moves the optional column filling earlier into the stack so one can add a portfolio with only the basic required columns.
Issues
#2444
Motivation
Trying to add a custom overwrite into Portfolio requires users to exactly match existing columns. This is slightly annoying since some users may have their own dataset transformers or sheets, and they want to pull only the required columns. This PR helps with that.
List any dependencies that are required for this change.How has this been tested?
Ran pytests and cleared.
Checklist:
Update our Hugo documentation following these guidelines.Update our tests following these guidelines.If a feature was added make sure to add it to the corresponding scripts file.Others
pre-commit install
.pytest tests/...
.