Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve export folder to custom one #2439

Merged
merged 3 commits into from
Aug 28, 2022
Merged

Improve export folder to custom one #2439

merged 3 commits into from
Aug 28, 2022

Conversation

DidierRLopes
Copy link
Collaborator

@deeleeramone
Copy link
Contributor

@DidierRLopes, the assignment of folders appears to work now. It would be a good idea to inform the user in the help dialogue that the path must be enclosed in quotation marks. There were problems with paths on PC/Linux, because the slash goes the other direction for those systems, so someone with a Windows and Linux OS should also test this for functionality.

One issue I have discovered is that: export default sets the exports folder as ~/OpenBBTerminal/openbb_terminal/exports, which is one folder too deep. The existing folder is at: ~/OpenBBTerminal/exports

Screen Shot 2022-08-27 at 1 24 57 PM

@DidierRLopes
Copy link
Collaborator Author

@deeleeramone done ✅

@DidierRLopes DidierRLopes merged commit 9731217 into main Aug 28, 2022
@Chavithra Chavithra deleted the 2345 branch September 20, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Paths set from the Settings menu creates a weird mess.
3 participants