Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Fix liquidations data. fixes OpenBB-finance/OpenBBTerminal#2429 #2430

Merged

Conversation

jfarid27
Copy link
Contributor

@jfarid27 jfarid27 commented Aug 27, 2022

Description

Inverts liquidations chart to correct axis. This makes the visualization match up exactly what is shown on CoinGlass.

Issue

#2429

Screenshot

Figure_1

Motivation

The long and short liquidations data was inverted. Unfortunately the documentation from Coinglass isn't great so this one slipped by. See issue #2429.

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

Local tests were updated for new data.

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@jfarid27 jfarid27 changed the title Fix liquidations data. fixes OpenBB-finance/OpenBBTerminal#2429 bug: Fix liquidations data. fixes OpenBB-finance/OpenBBTerminal#2429 Aug 27, 2022
@DidierRLopes DidierRLopes added the bug Fix bug label Aug 27, 2022
@DidierRLopes DidierRLopes self-requested a review August 27, 2022 14:21
Copy link
Collaborator

@DidierRLopes DidierRLopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding!

@DidierRLopes DidierRLopes merged commit 6291722 into OpenBB-finance:main Aug 27, 2022
@jfarid27 jfarid27 deleted the bugfix/invert-liquidations branch August 27, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants