Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix etf/compare #2426

Merged
merged 3 commits into from
Aug 26, 2022
Merged

fix etf/compare #2426

merged 3 commits into from
Aug 26, 2022

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented Aug 26, 2022

#2424

The json response from the site had changed. This fixes it

2022 Aug 26, 09:10 (🦋) /etf/ $ compare -e VOO,SPY

              ETF Comparisons              
┏━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃                ┃ VOO       ┃ SPY        ┃
┡━━━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Assets         │ $261.05B  │ $376.45B   │
├────────────────┼───────────┼────────────┤
│ NAV            │ $380.12   │ $413.51    │
├────────────────┼───────────┼────────────┤
│ Expense Ratio  │ 0.03%     │ 0.09%      │
├────────────────┼───────────┼────────────┤
│ PE Ratio       │ 20.20     │ 16.11      │
├────────────────┼───────────┼────────────┤

@jmaslek jmaslek added the bug Fix bug label Aug 26, 2022
@colin99d colin99d merged commit a285e5b into OpenBB-finance:main Aug 26, 2022
@jmaslek jmaslek deleted the etf_compare branch February 14, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin99d colin99d colin99d approved these changes

@JerBouma JerBouma Awaiting requested review from JerBouma

Assignees
No one assigned
Labels
bug Fix bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmaslek @colin99d