Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #2419 #2420

Merged
merged 3 commits into from
Aug 26, 2022
Merged

Conversation

nickvin
Copy link
Contributor

@nickvin nickvin commented Aug 25, 2022

Description

  • Summary of the change / bug fix.

Created folders required for exports to be completed successfully

  • Link # issue, if applicable.

Issue #2419

  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.

Export examples listed in issue # 2419 now work

  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@DidierRLopes
Copy link
Collaborator

@nickvin this is an empty PR. Is this intentional?

@nickvin
Copy link
Contributor Author

nickvin commented Aug 26, 2022

Intention was to create the missing folders to allow users cloning the repo to be able to successfully run export functions.

As referenced in #2419, some exports do not complete due to missing folders (while using the default export folder settings).

Export functions called in files located in /OpenBB-finance/openbb_terminal/common/, (e.g. feedparser_view.py) the export folder is set to be based off of os.path.dirname(os.path.abspath(__file__)) therefore requiring the common folder (and other sub-folders as well) to be present in OpenBBTerminal/exports/. Since OpenBBTerminal/exports/common/ does not exist in the repo in its current state, some export functions do not work.

Example:
image

This PR is meant to create the following folders/files to rectify the problem:
image

@colin99d colin99d added the bug Fix bug label Aug 26, 2022
@colin99d colin99d self-requested a review August 26, 2022 15:53
@colin99d
Copy link
Contributor

Thanks for the pr!

@colin99d colin99d merged commit b6a6b71 into OpenBB-finance:main Aug 26, 2022
@nickvin nickvin deleted the fix_path_with_export branch August 26, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants