-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat m: [Crypto/DD] Add Coinglass Liquidations #2402
feat m: [Crypto/DD] Add Coinglass Liquidations #2402
Conversation
Thank you for the contribution @jfarid27!! Looking good 🚀 |
[--export {csv,json,xlsx}] [-h] | ||
``` | ||
|
||
Display the liquidation data for a certain cryptocurrency. [Source: https://coinglass.github.io/API-Reference/] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this documentation ok? I would definitely request a review here to make sure it makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea it's fine, if you want to make it better you can add the image you uploaded there as a sneak peek
https://user-images.githubusercontent.com/1673206/186202157-31d1f6df-5f08-4849-98df-abb17c513fe1.png
"load", | ||
"fundrate", | ||
"oi", | ||
"liquidations", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a required ordering here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nop
Description
Issue
#2400
Screenshots
List any dependencies that are required for this change.How has this been tested?
Added new test suites for coinglass_model and ran VCR tests.
Checklist:
Others
pre-commit install
.pytest tests/...
.