Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat m: [Crypto/DD] Add Coinglass Liquidations #2402

Merged
merged 12 commits into from
Aug 23, 2022

Conversation

jfarid27
Copy link
Contributor

@jfarid27 jfarid27 commented Aug 23, 2022

Description

  • Adds crypto liquidations data from Coinglass to the dd menu for the loaded coin.
  • Adds tests for Coinglass model's existing functions. Previously tests were empty.

Issue

#2400

Screenshots

Figure_1

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • [] List any dependencies that are required for this change.

How has this been tested?

Added new test suites for coinglass_model and ran VCR tests.

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@jfarid27 jfarid27 changed the title [Crypto/DD] Add Coinglass Liquidations [feat M] (Crypto/DD) Add Coinglass Liquidations Aug 23, 2022
@jfarid27 jfarid27 changed the title [feat M] (Crypto/DD) Add Coinglass Liquidations feat m: [Crypto/DD] Add Coinglass Liquidations Aug 23, 2022
@colin99d colin99d added the feat M Medium T-Shirt size feature label Aug 23, 2022
@jfarid27 jfarid27 marked this pull request as ready for review August 23, 2022 15:43
@jose-donato
Copy link
Contributor

Thank you for the contribution @jfarid27!! Looking good 🚀

[--export {csv,json,xlsx}] [-h]
```

Display the liquidation data for a certain cryptocurrency. [Source: https://coinglass.github.io/API-Reference/]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this documentation ok? I would definitely request a review here to make sure it makes sense.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea it's fine, if you want to make it better you can add the image you uploaded there as a sneak peek

https://user-images.githubusercontent.com/1673206/186202157-31d1f6df-5f08-4849-98df-abb17c513fe1.png

"load",
"fundrate",
"oi",
"liquidations",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a required ordering here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat M Medium T-Shirt size feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants