Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nasdaq as an options source #2397

Merged
merged 18 commits into from
Aug 23, 2022

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented Aug 23, 2022

This PR adds nasdaq as an option source for chains, oi,vol,voi.

This actually allows pulling the entire chain in one command, so calculations for delta neutral as example could be performed.

Nasdaq allows for some things not carried on yahoo, like NDX (youre welcome danglewood).

Also going through shows a bunch of refactorings that need to go through, but that is out of the scope here.

@jmaslek jmaslek added the feat M Medium T-Shirt size feature label Aug 23, 2022
@jmaslek jmaslek requested a review from colin99d August 23, 2022 01:43
@colin99d
Copy link
Contributor

Screen Shot 2022-08-22 at 9 51 50 PM

Sad

@jmaslek
Copy link
Collaborator Author

jmaslek commented Aug 23, 2022

i uh didnt touch that one

@colin99d
Copy link
Contributor

colin99d commented Aug 23, 2022

Ok, while I will still approve this PR. I think it brings up an important refactor that needs to happen in the future. Currently, if I load with a non-default source, I then have to specify a source on every command I run. While this my not be hard on some, I have a full time job, a wife, and two kids at home. So I certainly don't have time to type --source=nasdaq after every command. I think a band aid fix for this in the near future would be having the controller remember your source, and a more long-term source would be to have all models send data in the same format to allow for standardization of views, thanks for coming to my Ted Talk.

@DidierRLopes
Copy link
Collaborator

Ok, while I will still approve this PR. I think it brings up an important refactor that needs to happen in the future. Currently, if I load with a non-default source, I then have to specify a source on every command I run. While this my not be hard on some, I have a full time job, a wife, and two kids at home. So I certainly don't have time to type --source=nasdaq after every command. I think a band aid fix for this in the near future would be having the controller remember your source, and a more long-term source would be to have all models send data in the same format to allow for standardization of views, thanks for coming to my Ted Talk.

I literally implemented this some weeks ago 😄 @colin99d

Screenshot 2022-08-23 at 08 56 39

@DidierRLopes DidierRLopes merged commit cf9b5ad into OpenBB-finance:main Aug 23, 2022
@jmaslek jmaslek deleted the nasdaq_options branch February 14, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat M Medium T-Shirt size feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants