-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nasdaq as an options source #2397
Conversation
i uh didnt touch that one |
Ok, while I will still approve this PR. I think it brings up an important refactor that needs to happen in the future. Currently, if I load with a non-default source, I then have to specify a source on every command I run. While this my not be hard on some, I have a full time job, a wife, and two kids at home. So I certainly don't have time to type |
1956b53
to
4c7c3aa
Compare
I literally implemented this some weeks ago 😄 @colin99d |
This PR adds nasdaq as an option source for
chains
,oi
,vol
,voi
.This actually allows pulling the entire chain in one command, so calculations for delta neutral as example could be performed.
Nasdaq allows for some things not carried on yahoo, like NDX (youre welcome danglewood).
Also going through shows a bunch of refactorings that need to go through, but that is out of the scope here.