Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing polygon api #2392

Merged
merged 7 commits into from
Aug 23, 2022

Conversation

nickvin
Copy link
Contributor

@nickvin nickvin commented Aug 22, 2022

Fixes #2373
Provides more concise error code when Polygon API key is missing

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

Copy link
Collaborator

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@DidierRLopes DidierRLopes added the enhancement Enhancement label Aug 22, 2022
@colin99d colin99d added bug Fix bug and removed bug Fix bug labels Aug 23, 2022
@DidierRLopes DidierRLopes merged commit 1e88223 into OpenBB-finance:main Aug 23, 2022
@nickvin nickvin deleted the fix_missing_polygon_api branch August 24, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Stocks/Codes: When no API key is present, user given the wrong error message: Error in polygon request
4 participants