Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFTs - added floor price and collections commands #2375

Merged
merged 12 commits into from
Aug 24, 2022
Merged

Conversation

jose-donato
Copy link
Contributor

Description

Will be updated, missing tests and docs

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@jose-donato jose-donato added the feat S Small T-Shirt size Feature label Aug 19, 2022
Copy link
Collaborator

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ctrl A
delete

@minhhoang1023 minhhoang1023 self-requested a review August 21, 2022 18:24
@minhhoang1023
Copy link
Contributor

minhhoang1023 commented Aug 21, 2022

Would be nice to have a plot of price floor for the top collections for comparison purposes
image

image

@jose-donato
Copy link
Contributor Author

Would be nice to have a plot of price floor for the top collections for comparison purposes image

image

that involves making one request for each collection but it's a nice suggestion

will make add a flag like --fp on collections command that will do what you suggested :)

@minhhoang1023
Copy link
Contributor

Can we use another color here? Yellow and orange on the same screen are not the best color combination. Or we can put them into a separate axis.

image

image

@minhhoang1023
Copy link
Contributor

Nice work! And go back to your pool - it's your vacay!

@jose-donato
Copy link
Contributor Author

Would be nice to have a plot of price floor for the top collections for comparison purposes image

image

image

@jose-donato
Copy link
Contributor Author

@Chavithra please assist a test noob :( added the mock for the api call in init

@minhhoang1023
Copy link
Contributor

This is a good one

image

@minhhoang1023
Copy link
Contributor

can we add a legend here?
image

Other than that, lgtm!

@jose-donato
Copy link
Contributor Author

jose-donato commented Aug 23, 2022

can we add a legend here? image

Other than that, lgtm!

image

since it's different axis i'm not sure if there is a better way of doing it

Copy link
Collaborator

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i hate doing this

@DidierRLopes DidierRLopes merged commit d399fce into main Aug 24, 2022
@jose-donato jose-donato deleted the nftpricefloor branch August 24, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat S Small T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants