-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests over API Best Practices #2344
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I know this isn't supposed to be until next sprint, but I had nothing else to do. Adds a super cool function that crawls our API and makes sure no parameter names are probably incorrect versions of standard parameter names. It's also super verbose to make fixing EZ. @minhhoang1023, let me know if there are common mistakes I need to add to the dictionary
Update: This PR found a LOT of places where we missed stuff (over 90). This will take me a decent amount of time to be ready.
I finished changing all of the bad functions. I am now trying to add a reliable way to check all of them. To do this I have added CI checks over our jupyter notebooks.
How has this been tested?
Ran pytest, add pytest coverage over jupyter notebooks.
Checklist:
Others
pre-commit install
.pytest tests/...
.