Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds relative strength percentile to stocks/ta #2302

Merged
merged 19 commits into from
Aug 22, 2022

Conversation

soggyomelette
Copy link
Contributor

@soggyomelette soggyomelette commented Aug 11, 2022

Description

Adds relative strength percentile to stocks/ta as requested in #2254
image

image

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

@soggyomelette soggyomelette marked this pull request as draft August 12, 2022 15:27
@Chavithra Chavithra added the feat XS Extra small feature label Aug 15, 2022
@soggyomelette soggyomelette marked this pull request as ready for review August 15, 2022 12:26
@JerBouma
Copy link
Contributor

Hi @soggyomelette,

Nice PR! Could you convert the "tickers" into a seperate table that a user can request with an optional argument? (and it won't show by default) It is now cut-off and you don't get much insights from it.

Copy link
Contributor

@JerBouma JerBouma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@soggyomelette soggyomelette merged commit 3a7401d into OpenBB-finance:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants