Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options tradier fix #2295

Merged
merged 4 commits into from
Aug 11, 2022
Merged

Options tradier fix #2295

merged 4 commits into from
Aug 11, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Aug 10, 2022

Description

Improves handling for Tradier when using options menu. Fixes #2117

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@colin99d colin99d requested a review from jmaslek August 10, 2022 23:28
@colin99d colin99d added the bug Fix bug label Aug 10, 2022
@colin99d colin99d merged commit fa5e62e into main Aug 11, 2022
@colin99d colin99d deleted the options_tradier branch August 11, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
2 participants