Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chains #2294

Merged
merged 3 commits into from
Aug 11, 2022
Merged

Fix chains #2294

merged 3 commits into from
Aug 11, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Aug 10, 2022

Description

Fixes #2288
Fixes #2216

How has this been tested?

Ran the tests with a ticker and now it worked.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@colin99d colin99d requested a review from jmaslek August 10, 2022 22:00
@colin99d colin99d added the bug Fix bug label Aug 10, 2022
@colin99d colin99d merged commit f507adc into main Aug 11, 2022
@colin99d colin99d deleted the fix_chains branch August 18, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
2 participants