Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added yfinance as a source and converted to pandas read_html #2286

Merged
merged 3 commits into from
Aug 10, 2022
Merged

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Aug 10, 2022

Description

Added yfinance as a source and did some cleaning up of data scraping methods. Could not find barchart data for penny stocks in the API, and scraping their website would be a pain (not formatted as a table). Fixes #2252

How has this been tested?

Reran items to see correct output.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@colin99d colin99d added bug Fix bug enhancement Enhancement labels Aug 10, 2022
@colin99d colin99d merged commit 317bca6 into main Aug 10, 2022
@colin99d colin99d deleted the penny branch August 10, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What it shows are not pennystocks /stocks/disc/ $ hotpenny
2 participants