Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bad yfinance urls #2282

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Fixed bad yfinance urls #2282

merged 2 commits into from
Aug 9, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Aug 9, 2022

Description

Fixes issues with scraping yfinance. Fixes #2272

How has this been tested?

Reran all the commands.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@colin99d colin99d added the bug Fix bug label Aug 9, 2022
@colin99d colin99d requested a review from jmaslek August 9, 2022 20:45
@colin99d colin99d merged commit bd12c20 into main Aug 9, 2022
@colin99d colin99d deleted the fix_screeners branch August 9, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stocks/disc not entirely working
2 participants