-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve SIA experience as based on feedback #2264
Conversation
DidierRLopes
commented
Aug 7, 2022
•
edited
Loading
edited
- Fixes [IMPROVE] Instead of exiting the terminal with CTRL + C, let it intercept the activated command #2201
@Chavithra can you help me with the tests here? |
Could you add in somewhere (e.g. within the progress bar description) that the user can cancel the process with |
Won't that kill the terminal process @JerBouma |
The whole point of this PR is to make an exception on that right? |
IIUC no, it's to disable default Sector/Industry |
@DidierRLopes literary links to my issue right? #2201 And we got this:
|
my brain is very smooth after this weekend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DidierRLopes Can you include a message either within the TQDM or somewhere else that it is clear that CTRL + C
cancels the process? This is not common knowledge.
I had done that, must have forgotten to push the changes 🤦🏽♂️ on it |