Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forgot to staple notarization to file #2250

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

simmonsj330
Copy link
Contributor

@simmonsj330 simmonsj330 commented Aug 5, 2022

Description

Forgot the most important part of notarization: actually stapling the accepted notarization to the dmg file.

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@simmonsj330 simmonsj330 added the build Build-related work label Aug 5, 2022
@simmonsj330 simmonsj330 self-assigned this Aug 5, 2022
@piiq piiq merged commit 168e2b9 into OpenBB-finance:main Aug 5, 2022
@simmonsj330 simmonsj330 deleted the forgot_to_staple branch August 5, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build-related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants