Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dcf growth #2244

Merged
merged 5 commits into from
Aug 5, 2022
Merged

added dcf growth #2244

merged 5 commits into from
Aug 5, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Aug 3, 2022

Description

Added the ability to use growth instead of linear regression for revenue predictions.

Fixes #2169.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@colin99d colin99d added the enhancement Enhancement label Aug 3, 2022
@colin99d colin99d requested a review from JerBouma August 3, 2022 18:30
Copy link
Contributor

@JerBouma JerBouma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JerBouma JerBouma merged commit 1e19ab5 into main Aug 5, 2022
@colin99d colin99d deleted the growth branch August 5, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IMPROVE] Add in growth rate for the DCF functionality
2 participants