Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds santiment to keys menu in response to #2224 #2238

Merged
merged 10 commits into from
Aug 5, 2022

Conversation

soggyomelette
Copy link
Contributor

@soggyomelette soggyomelette commented Aug 2, 2022

Adds santiment key in keys_controller.py as asked in fixes #2224 and also adds tests for santiment and messari keys in test_keys_controller.py

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.

image

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@colin99d colin99d added the feat S Small T-Shirt size Feature label Aug 2, 2022
@colin99d colin99d self-requested a review August 3, 2022 20:45
@colin99d
Copy link
Contributor

colin99d commented Aug 3, 2022

Great PR! Thanks for this.

@colin99d colin99d merged commit 824373c into OpenBB-finance:main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat S Small T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Add Santiment to keys menu
2 participants