Here we merge all API Refactor related branches #2236

Chavithra · 2022-08-02T16:23:12Z

Description

Here are the menus we are merging :

stocks (Diogo / Henrique / Colin) - reviewed by Minh & merged & needs to check again
crypto (Colin) reviewed by Minh & merged
economy (Diogo) being reviewed by Minh
portfolio (James / Diogo)
forex (Colin) reviewed by Minh & needs to check again
etf (Colin) needs to review
econometrics (Colin) needs to review
funds (Colin) needs to review
alt (Colin)

How has this been tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration.

Checklist:

Update our Hugo documentation following these guidelines.
Update our tests following these guidelines.
Make sure you are following our CONTRIBUTING guidelines.
If a feature was added make sure to add it to the corresponding scripts file.

Others

I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

colin99d · 2022-08-04T12:42:53Z

Big note: Do NOT do ANYTHING with pred menu stuff. This is removed by #1933 @Chavithra @minhhoang1023 @simmonsj330 @montezdesousa

minhhoang1023 · 2022-08-04T14:54:34Z

@colin99d You're super quick yo! 🚀

I'm testing it using all the API endpoints. Some of these functions might be in some types of helper. Comments are below:

We don't yet have a default value for the load function in forex. Docstring is missing on the description, and available options for resolution and intervals

api.forex.candle: here we require both the to_symbol and from_symbol just for the chart name. Is there anyway we can extract the symbol from the df? If not, perhaps has the empty string as default?

-api.forex.quote & api.forex.oanda.calendar it's nice to have the example documented in the docstring on the currency format, e.g. EUR, USD. Now it's not clear what format people should use

api.forex.oanda.candles: we should have in the docstring the available options for granularity param

…al into api-refactor

minhhoang1023 · 2022-08-12T11:28:31Z

To check before merging:

ascending -> ascend

descending -> descend

Also sort_by -> sortby

…api-refactor

simmonsj330 · 2022-08-15T16:12:04Z

@minhhoang1023 portfolio model & view will be done by today

* Refactored for etf commands * Fixed tests * Added load command * Fixed menu

* Added econometrics * Fixed tests * Simplified API * Added test fixes * Added test csv * Allowed examples to be loaded

* Fund refactor * Changed fund_name and fund to name * Changed ascending to ascend

* Stocks refactoring for easier API usage * Linting * Refactor newly added features * Linting * Fixing tests * Refactor common files used by stocks menu * Fixing flake8 * Fix linting and tests * Linting * Fix flake8 * refactor insider_data * refactor mentions * refactor watchlist * refactor sentiment * refactor sentiment * fix yahoofinance tests * refactor load and candle * refactor get_news and display_news * refactor stocks.ins.act * candle default matplotlib * fix yahoofinance_view tests * fix ark model tests * fix ark view tests * fix business insider model * fix business insider view * refactor csimarket model * fix tests csi market model * update dd controller * fix get suppliers tests * fix dd controller tests * fix finhub tests * fix finviz tests * fix fmp tests * fix marketwatch tests * corrected argument keywords in test_bt_model * corrected argument keywords in test_bt_view * refactor fa controller * refactor marketwatch view * refactor gov controller * fix tests fa av * fix tests elect * fix dcf tests * fix polygon tests * fix fmp tests * fix quiverquant tests * fix yahoofinance fa tests * fix more fa tests * fix insider tests * fix more tests * fix more tests * fix options tests * fix stock gov tests * fix tests test_ba_controller * fix tests for test_finviz_compare_model.py * fixed 2 tests * fixed tests * fixed tests * fixed tests * fixed tests * fixed tests * fixed tests * fixed tests * fixed tests * fixed tests * fixed tests * fix final tests * fixed tests * fixed tests * Fix tests * black * forgot to black tests * fixed tests * fixed tests * fixed tests * fixed tests * flakefix * Tests + code : Stocks / Discovery * fix tests * added recorder * fixed tests * fixed tests * black * black * remove unused imports * refactor display raw * sia dicts fix * pylint * linting * remove dangerous default * fix tests * fix beta model test * black * skip screener qa test * change sector path to sectors * update tests readme * fix metric defaults * black * substitute lost ticker * defaults cpic * another round on sia * refactor cramer * reduce default tweets on sentiment * refactor yf hist, corr, volume * arkorders default * refactor income, balance, cashflow * refacto scorr, screener, getfinnhub * refactor stockgrid * ibkr refactor * another round on stockgrid * add dividens end point * refactor discovery endpoints * update docstrings with similar input * refactor messages * refactor ba * refactor regioons * refactor twitter sentiment * refactor hist * refactor regions * give default to timeframe * refactor bunch of defaults and arg names * remove leftover imports * refactor vwap * let tests run * fix tests * fix stock tests * fix stockanalysis tests * flake * MYPY * Made important changes * added fixes * Fixed big issue * Added fixes to tests * fix qa tests * fix tests * fix 1 more test * last stocks failing * fix crypto test Co-authored-by: Chavithra PARANA <[email protected]> Co-authored-by: montezdesousa <[email protected]> Co-authored-by: hjoaquim <[email protected]> Co-authored-by: montezdesousa <[email protected]> Co-authored-by: colin99d <[email protected]>

…BBTerminal into api-refactor

Chavithra · 2022-08-17T13:15:56Z

Todo for next PR:

Few : ascending => ascend
Few : sort_by => sortby

Update api.py

43f07e1

Chavithra added the feat L Large T-Shirt size Feature label Aug 2, 2022

Chavithra requested review from minhhoang1023, simmonsj330 and montezdesousa August 2, 2022 16:23

Chavithra added feat XL Extra Large feature and removed feat L Large T-Shirt size Feature labels Aug 2, 2022

colin99d and others added 2 commits August 4, 2022 08:52

Updated forex menu

3d3fa17

Merge branch 'main' into api-refactor

d0ea930

montezdesousa and others added 10 commits August 4, 2022 17:50

refactor ycrv command

922953f

refactor ycrv command black

4794041

refactor ecocal command

01fb27c

Minh changes

154c17e

Adding space to test pushing

3296473

Merge branch 'api-refactor' of github.com:OpenBB-finance/OpenBBTermin…

611feaa

…al into api-refactor

title fix ecocal df

575d6c4

get economic calendar annotation

224bdab

fix investingcom tests

4e0a1c4

Merge branch 'main' into api-refactor

8fff9ee

piiq added do not merge Label to prevent pull request merge and removed do not merge Label to prevent pull request merge labels Aug 5, 2022

Chavithra marked this pull request as draft August 5, 2022 10:17

montezdesousa added 6 commits August 5, 2022 11:42

refactor index command

ca1242b

refactor overview command

1505192

give defaults to wsj view function args

7c273b9

rename date args investincom

d5eb50f

refacto bigmac command

650cc8c

fix ecocal typo

19fcfae

Chavithra and others added 7 commits August 12, 2022 14:22

Merge branch 'main' of github.com:OpenBB-finance/OpenBBTerminal into …

e6f82cf

…api-refactor

refactor arg currency

acbac1b

pylint from currency

a1dd34f

Started switching crpyto ascending to ascend

7c8c750

Merging

20d729e

Merging

1a78eb6

Portfolio model arguements, params, and docstring

5113cd0

colin99d and others added 8 commits August 15, 2022 15:13

Refactored for etf commands (#2292)

30fe24d

* Refactored for etf commands * Fixed tests * Added load command * Fixed menu

Portfolio logic fixes

02d8abf

Added econometrics (#2260)

315e118

* Added econometrics * Fixed tests * Simplified API * Added test fixes * Added test csv * Allowed examples to be loaded

Fund refactor (#2291)

032acf8

* Fund refactor * Changed fund_name and fund to name * Changed ascending to ascend

Merge branch 'main' into api-refactor

c5aae1e

fix portfolio tests

ededf9f

change period to window

1264463

montezdesousa marked this pull request as ready for review August 17, 2022 10:36

montezdesousa and others added 4 commits August 17, 2022 12:11

update ca docstrings

d1e2a73

refactor get_similar_companies func

5c26ef9

Fixed

07cce3a

Merge branch 'api-refactor' of https://github.com/OpenBB-finance/Open…

69298ed

…BBTerminal into api-refactor

Chavithra added 3 commits August 17, 2022 15:25

Update CI

07dbee2

Update CI 2

0f80d07

Update CI 3

15d9145

minhhoang1023 approved these changes Aug 17, 2022

View reviewed changes

Update dependencies

18712ac

minhhoang1023 merged commit 9e1a58e into main Aug 17, 2022

Chavithra deleted the api-refactor branch August 17, 2022 14:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Here we merge all API Refactor related branches #2236

Here we merge all API Refactor related branches #2236

Chavithra commented Aug 2, 2022 •

edited by montezdesousa

Loading

colin99d commented Aug 4, 2022 •

edited

Loading

minhhoang1023 commented Aug 4, 2022 •

edited

Loading

minhhoang1023 commented Aug 12, 2022 •

edited

Loading

simmonsj330 commented Aug 15, 2022 •

edited

Loading

Chavithra commented Aug 17, 2022

Here we merge all API Refactor related branches #2236

Here we merge all API Refactor related branches #2236

Conversation

Chavithra commented Aug 2, 2022 • edited by montezdesousa Loading

Description

How has this been tested?

Checklist:

Others

colin99d commented Aug 4, 2022 • edited Loading

minhhoang1023 commented Aug 4, 2022 • edited Loading

minhhoang1023 commented Aug 12, 2022 • edited Loading

simmonsj330 commented Aug 15, 2022 • edited Loading

Chavithra commented Aug 17, 2022

Chavithra commented Aug 2, 2022 •

edited by montezdesousa

Loading

colin99d commented Aug 4, 2022 •

edited

Loading

minhhoang1023 commented Aug 4, 2022 •

edited

Loading

minhhoang1023 commented Aug 12, 2022 •

edited

Loading

simmonsj330 commented Aug 15, 2022 •

edited

Loading