Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay Portfolio and Benchmark Returns Distributions #2233

Merged
merged 10 commits into from
Aug 29, 2022
Merged

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Aug 2, 2022

Description

This PR fixes #2218 by overlaying portfolio and benchmark plots as suggested. Still have to add line marker/summary stats.

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@montezdesousa montezdesousa added enhancement Enhancement do not merge Label to prevent pull request merge labels Aug 2, 2022
@DidierRLopes
Copy link
Collaborator

What's the status of this one?

@montezdesousa
Copy link
Contributor Author

What's the status of this one?

Same status, API got in the way. Though I think just the detail of overlaying the curves is a "quality increment" and stats are already exposed through --raw. So we could just merge this detail if you agree.

Before:
image

After:
image

@montezdesousa montezdesousa marked this pull request as ready for review August 27, 2022 17:22
@DidierRLopes
Copy link
Collaborator

@montezdesousa yes I agree. Let's do that!

@montezdesousa montezdesousa removed the do not merge Label to prevent pull request merge label Aug 28, 2022
@montezdesousa montezdesousa merged commit 5e54660 into main Aug 29, 2022
@montezdesousa montezdesousa deleted the distplot branch August 29, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IMPROVE] Overlay Portfolio and Benchmark Returns Distributions
3 participants