Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating intel macos build system #2229

Merged
merged 3 commits into from
Aug 2, 2022
Merged

Updating intel macos build system #2229

merged 3 commits into from
Aug 2, 2022

Conversation

simmonsj330
Copy link
Contributor

@simmonsj330 simmonsj330 commented Aug 2, 2022 •
edited
Loading

Description

Adding self hosted runners, integration tests, code signing, and notarization.

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@simmonsj330 simmonsj330 added the build Build-related work label Aug 2, 2022
@simmonsj330 simmonsj330 self-assigned this Aug 2, 2022
@simmonsj330 simmonsj330 force-pushed the intel_macos_build_system_update branch from 6577020 to 0a18ce1 Compare August 2, 2022 19:34
@simmonsj330 simmonsj330 merged commit 71ec70e into OpenBB-finance:main Aug 2, 2022
@simmonsj330 simmonsj330 deleted the intel_macos_build_system_update branch August 2, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chavithra Chavithra Chavithra approved these changes

@piiq piiq Awaiting requested review from piiq

Assignees

@simmonsj330 simmonsj330

Labels
build Build-related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simmonsj330 @Chavithra