-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update latest allowed python version to 3.10.x #2208
Conversation
Can confirm that above steps were also successful on Arch Linux under python 3.10.5 |
I attempted this by installing Python 3.10.5 from my base Conda environment. I made the change to the file shown, then after confirming that Python 3.10.5 was the active version I ran
Then launching the terminal, and attempting to enter the prediction menu, with a M1 Mac Pro, I received the Python version is 3.9.9, despite my starting point at 3.10.5 |
Hello @deeleeramone thanks for looking into this. Unlike conda, poetry is installed per env. It is entirely possible that poetry was attempting to run against |
Hi @lotia, I deleted the Poetry environment, but I'll have another go at installing this way. I can assure you that between @piiq, @martinb-bb, and myself, we have spent a lot of time messing around with the dependency chain, figuring out what package distributions do not work. @piiq is probably the best person you could connect with to attempt to iron out a viable solution. On the plus side, it is entirely possible to run the Terminal from Python 3.10.5 & 3.10.7, on a Mac M1 as well as a legacy Mac Pro system running OS Catalina. This was accomplished by installing with I have not tested for errors, but on the surface things appear to work. |
Pystan may be a problem that blocks the Terminal from 3.10. The poetry installation fails and there is no Conda distribution for 3.10. |
I'll close the PR for now and continue with the latest stable 3.9.x. Thanks for the time you have put in and apologies if it was annoying. |
It worked for me. I wouldn't about |
It shouldnt affect too much. Will have to do testing for sure ! |
Please freel free to open or ask me to rebase if/when we can sort out. I'm excited by the push the PSF has towards performance improvments in 3.10 and the upcoming ones in 3.11 specially since you folks have so much cool prediction/simulation functionality available |
Description
This PR raises the latest allowed python version 3.10.x which is the latest minor version.
How has this been tested?
I have run the test suite using
pytest tests
and although tests were skipped, there were no failures. This was done on macOS 12.4 on which python is managed using asdf and the python plugin for asdf.To reproduce
Install a current 3.10.x version of python, in my case I use the asdf version manager and the associated python plugin.
Confirm you are using that python version in your current shell using
python --version
Install poetry
Install all dependencies including optional ones
Activate the poetry shell
Run test suite
This should enable you to confirm (hopefully) that all dependencies install cleanly using just poetry and also that the test suite does not have any failures, although some tests are skipped.
Others
pre-commit install
.pytest tests/...
.