Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved verbosity of dd rating failure, and add color to the chart #2204

Merged
merged 5 commits into from
Jul 29, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Jul 29, 2022

Description

Fixes #2195 by showing what the error received and makes the chart that is printed show in color (removed a TODO)

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@colin99d colin99d requested a review from jmaslek July 29, 2022 19:21
@colin99d colin99d added the bug Fix bug label Jul 29, 2022
@colin99d colin99d merged commit da337ab into main Jul 29, 2022
@colin99d colin99d deleted the dd_rating branch July 29, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature $stocks/load gme/dd/rating doesn't seem to be working
2 participants