Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fixes for coinbase #2202

Merged
merged 3 commits into from
Jul 29, 2022
Merged

Added fixes for coinbase #2202

merged 3 commits into from
Jul 29, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Jul 29, 2022

Description

Fixes #2186

@deeleeramone I have no way of testing this, can you please see if it fixes.

How has this been tested?

By Darren (:.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@colin99d colin99d added the bug Fix bug label Jul 29, 2022
@DidierRLopes DidierRLopes merged commit 37e2597 into main Jul 29, 2022
@colin99d colin99d deleted the fix_coinbase branch August 5, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Keys - Coinbase function is broken. Key can only be set through .env
3 participants