Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News from feedparser + Binance API key check fix #2192

Merged
merged 13 commits into from
Jul 29, 2022
Merged

News from feedparser + Binance API key check fix #2192

merged 13 commits into from
Jul 29, 2022

Conversation

DidierRLopes
Copy link
Collaborator

@DidierRLopes DidierRLopes commented Jul 28, 2022

image

Missing documentation, let me know if you like it! 👍🏽

@DidierRLopes DidierRLopes added bug Fix bug feat XS Extra small feature labels Jul 28, 2022
@DidierRLopes DidierRLopes changed the title News News from feedparser + Binance API key check fix Jul 28, 2022
@jmaslek
Copy link
Collaborator

jmaslek commented Jul 28, 2022

load aapl/news

> Wed, 27 Jul 2022 20:31:00 GMT - Apple Inc. stock rises Wednesday, still underperforms market - MarketWatch
https://www.marketwatch.com/story/apple-inc-stock-rises-wednesday-still-underperforms-market-01658953916-a3a605a9db79

> Thu, 28 Jul 2022 13:57:27 GMT - Apple Stock Surge Raises Stakes as Earnings Loom - Bloomberg
https://www.bloomberg.com/news/articles/2022-07-28/apple-stock-surge-raises-stakes-as-earnings-loom-tech-watch

> Thu, 28 Jul 2022 14:12:00 GMT - Apple's privacy changes, TikTok competition inescapable for Meta, for now - Reuters
https://www.reuters.com/technology/apples-privacy-changes-tiktok-competition-inescapable-meta-now-2022-07-28/

> Thu, 28 Jul 2022 01:37:33 GMT - Apple Q3 FY2022 Earnings Report Preview: What to Look For - Investopedia
https://www.investopedia.com/apple-q3-fy2022-earnings-report-preview-6281130

> Mon, 25 Jul 2022 22:08:04 GMT - Steve Jobs' original Apple 1 computer prototype up for auction - Fox Business
https://www.foxbusiness.com/lifestyle/steve-jobs-original-apple-1-computer-prototype-auction

Not in order of date?

@jmaslek
Copy link
Collaborator

jmaslek commented Jul 28, 2022

news -h not updated :P

usage: news [--article ARTICLE [ARTICLE ...]] [-h] [--export EXPORT] [-l LIMIT] [--source {feedparser,newsapi}]

Prints latest news about company, including date, title and web link. [News API]

options:
  --article ARTICLE [ARTICLE ...]
                        stocks/NEWS_data
  -h, --help            show this help message
  --export EXPORT       Export raw data into csv, json, xlsx
  -l LIMIT, --limit LIMIT
                        Number of entries to show in data.
  --source {feedparser,newsapi}
                        Data source to select from

For more information and examples, use 'about news' to access the related guide.
`

@DidierRLopes
Copy link
Collaborator Author

load aapl/news

> Wed, 27 Jul 2022 20:31:00 GMT - Apple Inc. stock rises Wednesday, still underperforms market - MarketWatch
https://www.marketwatch.com/story/apple-inc-stock-rises-wednesday-still-underperforms-market-01658953916-a3a605a9db79

> Thu, 28 Jul 2022 13:57:27 GMT - Apple Stock Surge Raises Stakes as Earnings Loom - Bloomberg
https://www.bloomberg.com/news/articles/2022-07-28/apple-stock-surge-raises-stakes-as-earnings-loom-tech-watch

> Thu, 28 Jul 2022 14:12:00 GMT - Apple's privacy changes, TikTok competition inescapable for Meta, for now - Reuters
https://www.reuters.com/technology/apples-privacy-changes-tiktok-competition-inescapable-meta-now-2022-07-28/

> Thu, 28 Jul 2022 01:37:33 GMT - Apple Q3 FY2022 Earnings Report Preview: What to Look For - Investopedia
https://www.investopedia.com/apple-q3-fy2022-earnings-report-preview-6281130

> Mon, 25 Jul 2022 22:08:04 GMT - Steve Jobs' original Apple 1 computer prototype up for auction - Fox Business
https://www.foxbusiness.com/lifestyle/steve-jobs-original-apple-1-computer-prototype-auction

Not in order of date?

It doesn't has order of data, but we are only grabbing data from past 24 hours. So thought it wouldn't matter much. Thoughts?

@DidierRLopes
Copy link
Collaborator Author

@jmaslek wth is going on here?

@jmaslek
Copy link
Collaborator

jmaslek commented Jul 29, 2022

It doesn't has order of data, but we are only grabbing data from past 24 hours. So thought it wouldn't matter much. Thoughts?

That screenshot has articles from 3 different days so kinda confusing. Sorting would be ideal to get newer first, but if its not possible atm, or you don't have time, is fine for now.

@jmaslek
Copy link
Collaborator

jmaslek commented Jul 29, 2022

@jmaslek wth is going on here?

you fucked it up 😅

@DidierRLopes DidierRLopes merged commit 8eed33b into main Jul 29, 2022
@colin99d colin99d deleted the news branch August 5, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants