Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix/Stocks/KeyMetricsExport] Add export call to FA key metrics controller #2184

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

asymness
Copy link
Contributor

Description

  • Summary of the change / bug fix.
    The stocks/fa/key call does not handle the --export parameter even though it is documented.
  • Link # issue, if applicable: [Bug] /stocks/fa/key: --export does not function. #2181
  • Screenshot of the feature or the bug before/after fix, if applicable.
    Before

image

**After**

image

  • Relevant motivation and context: Prior to this change, user can not export key metrics of a stock.
  • List any dependencies that are required for this change: N/A

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
    Running stocks >> load goog >> fa >> key --export xlsx after the change saves an export file which does not get exported without this change.

  • Provide instructions so we can reproduce.
    Running stocks >> load goog >> fa >> key --export xlsx, no file is exported.

  • Please also list any relevant details for your test configuration.
    N/a

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@DidierRLopes DidierRLopes added the enhancement Enhancement label Jul 26, 2022
Copy link
Collaborator

@DidierRLopes DidierRLopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thank you!

@DidierRLopes DidierRLopes merged commit d085018 into OpenBB-finance:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants