[Bugfix/TradeBalance] Fix parameter name for TradeBalance and handle 'null' response from EconDB API #2179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
economy/macro
for Trade Balance was incorrect (TBFR
) which is specific to France. The general parameter name should beTB
. I.e.TB<country_code>
null
response with 200 status code which raises an error "NoneType object is not subscriptable", the second commit fixes this issue by checking the response content before trying to parse it into a Series.Before
After
economy/macro
.How has this been tested?
Please describe the tests that you ran to verify your changes.
Ran macro command for various countries using
TB
parameter.Provide instructions so we can reproduce.
Run Trade Balance indicator using
TBFR
parameter with any country to reproduce ineconomy/macro
.Please also list any relevant details for your test configuration.
N/A
Checklist:
Others
pre-commit install
.pytest tests/...
.