-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Survey command and info, more documentation and bugfixes #2174
Conversation
about
about
… into link_promotions
…erminal into link_promotions
Thanks for setting this up Jer! 🙌 @piiq @andrewkenreich A quick question about the installer! My idea is that we can add the Survey link in the exit message for the Terminal. @JerBouma mentioned that it will only appear when people type |
If the user closes the window the window just closes and there is no exit per se. We can display survey link in the start message, or in some other place |
Fixed the survey command not working. Does it matter much it isn't a static method? |
@JerBouma it's software engineering best practice. So that an instance doesn't have to be instantiated each time you call it. It would take less than 1 min to fix it, and we can keep the code base to a high-quality standard. |
Awesome! Working now 🚀 |
Could you suggest how? |
For the survey, we could add "Take 2 mins to fill in our survey" or "Fill in our 2-minute survey". Letting people know that this is extremely QUICK to do! Looks great overall |
Just need to add the @staticmethod and remove the self. Like this
|
Done done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGG
This PR does the following:
survey
that opens the most recent survey.about
, I noticed that within theta
menu typingabout
doesn't work since it adds in "terminal" twice. This was a very minor fix from changing an if-statement to elif.settings
,featflags
andsources
which now has a proper section in the Getting Started page.The link, https://openbb.co/survey, still needs to be defined.