Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed DCF Handling #2160

Merged
merged 1 commit into from
Jul 24, 2022
Merged

Fixed DCF Handling #2160

merged 1 commit into from
Jul 24, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Jul 24, 2022

Description

Fixes #2151

How has this been tested?

Ran tests

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@colin99d colin99d added the bug Fix bug label Jul 24, 2022
@DidierRLopes
Copy link
Collaborator

Hello darkness my old friend 🤣

@DidierRLopes DidierRLopes merged commit fa1c796 into main Jul 24, 2022
@colin99d colin99d deleted the fix_dcf branch July 24, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]Stocks/FA/DCF - DCF function unable to handle nan values: Error: could not convert string to float: '-'
3 participants