-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace crypto exchange apis with CCXT #2158
Conversation
Don't forget to update the website content as well 😄 |
Yup it's still a WIP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of requests
return ccxt.exchanges | ||
|
||
|
||
def get_orderbook(exchange_id: str, coin: str, vs: str): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add return type with the -> Dict
vs : str | ||
currency to compare coin against | ||
export : str | ||
Export dataframe data to csv,json,xlsx file""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The """
should be 1 line below
top : int | ||
number of trades to display | ||
export : str | ||
Export dataframe data to csv,json,xlsx file""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"""
one line below
if not df_mt.empty: | ||
self.messari_timeseries = df_mt.index.to_list() | ||
if session and obbff.USE_PROMPT_TOOLKIT: | ||
choices: dict = {c: {} for c in self.controller_choices} | ||
choices["load"]["--source"] = {c: None for c in CRYPTO_SOURCES.keys()} | ||
choices["ob"]["-e"] = {c: None for c in self.ccxt_exchanges} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add:
choices["ob"] = {c: None for c in self.ccxt_exchanges}
choices["ob"]["-e"] = {c: None for c in self.ccxt_exchanges}
choices["trades"] = {c: None for c in self.ccxt_exchanges}
choices["trades"]["-e"] = {c: None for c in self.ccxt_exchanges}
Description
How has this been tested?
Checklist:
Others
pre-commit install
.pytest tests/...
.