Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace crypto exchange apis with CCXT #2158

Merged
merged 8 commits into from
Jul 26, 2022
Merged

Replace crypto exchange apis with CCXT #2158

merged 8 commits into from
Jul 26, 2022

Conversation

jose-donato
Copy link
Contributor

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@jose-donato jose-donato added the feat XS Extra small feature label Jul 24, 2022
@jose-donato jose-donato changed the title Ccxt Replace crypto exchange apis with CCXT Jul 24, 2022
@DidierRLopes
Copy link
Collaborator

Don't forget to update the website content as well 😄

@jose-donato
Copy link
Contributor Author

Don't forget to update the website content as well 😄

Yup it's still a WIP

@DidierRLopes
Copy link
Collaborator

Can we allow to not add a "-e":

Screenshot 2022-07-26 at 01 08 05

Copy link
Collaborator

@DidierRLopes DidierRLopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of requests

return ccxt.exchanges


def get_orderbook(exchange_id: str, coin: str, vs: str):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add return type with the -> Dict

vs : str
currency to compare coin against
export : str
Export dataframe data to csv,json,xlsx file"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The """ should be 1 line below

top : int
number of trades to display
export : str
Export dataframe data to csv,json,xlsx file"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

""" one line below

if not df_mt.empty:
self.messari_timeseries = df_mt.index.to_list()
if session and obbff.USE_PROMPT_TOOLKIT:
choices: dict = {c: {} for c in self.controller_choices}
choices["load"]["--source"] = {c: None for c in CRYPTO_SOURCES.keys()}
choices["ob"]["-e"] = {c: None for c in self.ccxt_exchanges}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add:

choices["ob"] = {c: None for c in self.ccxt_exchanges}
choices["ob"]["-e"] = {c: None for c in self.ccxt_exchanges}
choices["trades"] = {c: None for c in self.ccxt_exchanges}
choices["trades"]["-e"] = {c: None for c in self.ccxt_exchanges}

@jose-donato jose-donato merged commit cace78c into main Jul 26, 2022
@jose-donato jose-donato deleted the ccxt branch July 26, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants