Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates crypto load docs to match last load refactor #2154

Merged
merged 3 commits into from
Jul 24, 2022
Merged

Conversation

jose-donato
Copy link
Contributor

No description provided.

@jose-donato jose-donato changed the title Updates crypto load docs to match new load refactor Updates crypto load docs to match last load refactor Jul 24, 2022
@DidierRLopes DidierRLopes added the docs Code documentation label Jul 24, 2022
Copy link
Collaborator

@DidierRLopes DidierRLopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deeleeramone created a ticket to add more granularity on the data. FYI 😋

Copy link
Collaborator

@DidierRLopes DidierRLopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change the closes[:-365] to closes[:365]

@jose-donato
Copy link
Contributor Author

Why did you change the closes[:-365] to closes[:365]

i think there was an error. that column was displaying NaN. why would it be -365?

@DidierRLopes
Copy link
Collaborator

Why did you change the closes[:-365] to closes[:365]

i think there was an error. that column was displaying NaN. why would it be -365?

There's actually an issue, it should be closes[-365:] - this is so that we take the last 365 days from the data to calculate volatility

@DidierRLopes DidierRLopes merged commit 045168e into main Jul 24, 2022
@colin99d colin99d deleted the fix_load branch August 5, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Code documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants