Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ycrv to allow raw display and export when source is FRED #2127

Merged
merged 4 commits into from
Jul 21, 2022

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Jul 21, 2022

Description

This PR fixes the --raw and --export outputs when ycrv --source FRED --raw --export csv is used. Currently, those flags only work for the default source investpy. If user picks FRED he cannot display raw data or export it to csv.

image

  • Summary of the change / bug fix.
  • Relevant motivation and context.

Test:
ycrv --source FRED -d 2021-01-04 --raw --export csv

Others

  • I have performed a self-review of my own code.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@montezdesousa montezdesousa added the bug Fix bug label Jul 21, 2022
@montezdesousa montezdesousa added the enhancement Enhancement label Jul 21, 2022
@montezdesousa montezdesousa marked this pull request as ready for review July 21, 2022 22:59
@jmaslek
Copy link
Collaborator

jmaslek commented Jul 21, 2022

Should we include logic that if a country is selected AND fred source, that it won't work. Namely

ycrv -c canada --source FRED

gives US yield curve

@montezdesousa montezdesousa merged commit b439580 into main Jul 21, 2022
@montezdesousa montezdesousa deleted the ycrv_raw branch July 21, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants