Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] (XS DevOps) Add jupyterlab build folders to .gitignore. #2122

Merged

Conversation

jfarid27
Copy link
Contributor

Description

Adds jupyterlab build folders to .gitignore. Currently the build process when setting up creates build folders when following jupyterlab instructions.

Resolves #2121

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

Personal testing. This is just a git addition and affects development operations.

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@@ -40,6 +40,7 @@ DMG/*
*.dmg

# Jupyter Lab Extension build files
jupyterlab/**/build
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One line of fixes really. Just add this to the .gitignore.

@jfarid27 jfarid27 changed the title [Improvement] (DevOps) Add jupyterlab build folders to .gitignore. [Enhancement] (DevOps) Add jupyterlab build folders to .gitignore. Jul 21, 2022
@jfarid27 jfarid27 changed the title [Enhancement] (DevOps) Add jupyterlab build folders to .gitignore. [Feature] (XS DevOps) Add jupyterlab build folders to .gitignore. Jul 21, 2022
@piiq piiq added build Build-related work jupyterlab Jupyter Lab integration labels Jul 21, 2022
@piiq piiq merged commit 2edc04c into OpenBB-finance:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build-related work jupyterlab Jupyter Lab integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IMPROVE] (jupyterlab) Add jupyterlab build folders to .gitignore
2 participants