Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding data range for VaR #2087

Merged
merged 2 commits into from
Jul 14, 2022

Conversation

pftp-jz
Copy link
Contributor

@pftp-jz pftp-jz commented Jul 14, 2022

Description

its a small / extra small feature

Simple change to VaR function for stocks, this will allow users to use data ranges for the analysis
This way you wont need to load amazon 3 times, to make the analysis from 2019 to today, this month and this week

How has this been tested?

Check Command Documentation..............................................Passed
check yaml...........................................(no files to check)Skipped
fix end of files.....................................(no files to check)Skipped
trim trailing whitespace.............................(no files to check)Skipped
check for merge conflicts................................................Passed
detect private key.......................................................Passed
black....................................................................Passed
flake8...................................................................Passed
codespell................................................................Passed
mypy.....................................................................Passed
Strip notebooks output...............................(no files to check)Skipped
Passted all tests in stocks/quantitative_analysis
passed all tests for qa_view
was used in terminal as a test

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@DidierRLopes DidierRLopes added the bug Fix bug label Jul 14, 2022
@DidierRLopes
Copy link
Collaborator

Thanks @pftp-jz !

Can you add this # pylint: disable=C0302 between imports and code?

@pftp-jz
Copy link
Contributor Author

pftp-jz commented Jul 14, 2022

Done

Thanks @pftp-jz !

Can you add this # pylint: disable=C0302 between imports and code?

@DidierRLopes DidierRLopes merged commit 5fc2635 into OpenBB-finance:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants