Fast Merge - Updating README.md from top folder, CONTRIBUTING.md wrong link #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'OpenBB-finance/OpenBBTerminal' repository doesn't contain the 'openbb_terminal/CONTRIBUTING.md' path in 'main'.
CONTRIBUTING.md link was pointed to openbb_terminal folder, when it was supposed to be pointed to the main folder
Also both are pointing to master folder, and they are being redirected via "Branch not found, redirected to default branch." :
Maybe update to https://github.com/OpenBB-finance/OpenBBTerminal/blob/main/CONTRIBUTING.md ?
but either way https://github.com/OpenBB-finance/OpenBBTerminal/tree/master/CONTRIBUTING.md would still redirect correctly
jmaslek
approved these changes
Jul 13, 2022
jmaslek
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'OpenBB-finance/OpenBBTerminal' repository doesn't contain the 'openbb_terminal/CONTRIBUTING.md' path in 'main'.
CONTRIBUTING.md link was pointed to openbb_terminal folder, when it was supposed to be pointed to the main folder
Also both are pointing to master folder, and they are being redirected via "Branch not found, redirected to default branch." :
Maybe update to https://github.com/OpenBB-finance/OpenBBTerminal/blob/main/CONTRIBUTING.md ?
but either way https://github.com/OpenBB-finance/OpenBBTerminal/tree/master/CONTRIBUTING.md would still redirect correctly
How has this been tested?
At least for me clicking the link in the current repo goes to the wrong link
Current link
https://github.com/OpenBB-finance/OpenBBTerminal/tree/main/openbb_terminal/CONTRIBUTING.md
-> wrong path
New link Options
https://github.com/OpenBB-finance/OpenBBTerminal/blob/main/CONTRIBUTING.md
-> link to the correct repo branch "main"
https://github.com/OpenBB-finance/OpenBBTerminal/tree/master/CONTRIBUTING.md
-> link to master, the same as was being used but for wrong folder, and same as used for Getting started link which is working, but being redirect to /blob/main