Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes portfolio_model.py tests #2071

Merged
merged 3 commits into from
Jul 12, 2022
Merged

Fixes portfolio_model.py tests #2071

merged 3 commits into from
Jul 12, 2022

Conversation

montezdesousa
Copy link
Contributor

Description

This PR fixes portfolio_model.py tests: test_tail_ratio and test_common_sense_ratio which expected output had to be constantly rewrite.

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@montezdesousa montezdesousa added the bug Fix bug label Jul 12, 2022
@Chavithra Chavithra requested review from Chavithra and removed request for Chavithra July 12, 2022 08:53
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should fix the recurrent test issue.

Improvement : allowing changing the datetime.now() used by some function inside portfolio_model module by a parameter.

@Chavithra Chavithra merged commit dfd6d49 into main Jul 12, 2022
@Chavithra Chavithra deleted the portfolio_tests_fix branch July 12, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants