Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document : Change Docker container desktop pass-through #2070

Merged
merged 15 commits into from
Jul 18, 2022

Conversation

dreamerc
Copy link
Contributor

Update #1692 for Docker new security protection in 2022 .

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

Update OpenBB-finance#1692 for Docker new security protection in 2022 .
@piiq piiq requested a review from JerBouma July 12, 2022 09:30
@piiq piiq added the docs Code documentation label Jul 12, 2022
@DidierRLopes DidierRLopes requested a review from piiq July 13, 2022 10:41

#### Setting up X Quartz/X11

0. Install X Quartz from <https://www.xquartz.org/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still do need x11 don't we?
for xhost + to work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because Linux Desktop was built with X11.
For remote user in Linux, common case is using SSH X-forwarding.
Run command , and it likes :

ssh -X [email protected] 'desktop-app-command'

In Mac/Windows , you need Quartz/Xming to do this. [1]

  1. https://kb.iu.edu/d/bdnt - Use X forwarding on a personal computer to securely run graphical applications installed on IU's research supercomputers

@piiq
Copy link
Contributor

piiq commented Jul 18, 2022

It seems that setting the Qt backend for matplotlib is optional as tkinter is default on the host, but using the socket is far better that using the IP address

@dreamerc can you please undo the deletion of the instructions to install the XQuartz (critical for macOS users) and sync your PR with latest main for the tests to pass. After that we should merge this.

@DidierRLopes DidierRLopes merged commit f0a4551 into OpenBB-finance:main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Code documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants