Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python version #2061

Merged
merged 14 commits into from
Jul 12, 2022
Merged

Bump python version #2061

merged 14 commits into from
Jul 12, 2022

Conversation

piiq
Copy link
Contributor

@piiq piiq commented Jul 8, 2022

Description

This PR upgrades the default python version to 3.9 in the dependencies and the documentation. This introduces the following features and fixes:

To test this PR recreate your conda environment following the updated documentation:

On M1 macs:

conda env remove -n gst
conda env create -n gst --file build/conda/conda-3-9-env.yaml
conda activate gst
poetry install
conda install -c apple tensorflow-deps
poetry install -E prediction-m1-mac

On all other platforms:

conda env remove -n gst
conda env create -n gst --file build/conda/conda-3-9-env.yaml
conda activate gst
poetry install
poetry install -E prediction

and run integrated tests for the terminal:

python terminal.py scripts/*.openbb -t

@piiq piiq added the dependencies Work related to dependencies label Jul 8, 2022
@piiq piiq self-assigned this Jul 8, 2022
@piiq
Copy link
Contributor Author

piiq commented Jul 8, 2022

the integration tests produced the following errors:

GamestonkTerminal/scripts/test_econometrics_panel.openbb: 'NoneType' object has no attribute 'name'
GamestonkTerminal/scripts/test_econometrics_ts.openbb: 'NoneType' object has no attribute 'name'
GamestonkTerminal/scripts/test_crypto_dd.openbb: 429 Client Error: Too Many Requests for url: https://api.coingecko.com/api/v3/coins/list
GamestonkTerminal/scripts/test_crypto_ov.openbb: 'Highest'
GamestonkTerminal/scripts/test_economy.openbb: cannot do slice indexing on DatetimeIndex with these indexers  of type str
GamestonkTerminal/scripts/test_stocks_options.openbb: Expiration `2022-07-08` cannot be found. Available expiration are: [2022-07-15, 2022-09-16, 2023-01-20, 2023-03-17, 2023-06-16, 2023-09-15, 2024-01-19]

@simmonsj330 simmonsj330 marked this pull request as ready for review July 8, 2022 15:53
@piiq
Copy link
Contributor Author

piiq commented Jul 8, 2022

@JerBouma @Chavithra can you look if this works on windows? The test commands are in the PR description

Copy link
Contributor

@simmonsj330 simmonsj330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@simmonsj330 simmonsj330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would changing the old version fallback tag to be done every version increase?

@piiq piiq added the build Build-related work label Jul 12, 2022
@piiq
Copy link
Contributor Author

piiq commented Jul 12, 2022

Would changing the old version fallback tag to be done every version increase?

Yes

@piiq piiq merged commit 5267af2 into main Jul 12, 2022
@piiq piiq deleted the bump-python-version branch July 12, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build-related work dependencies Work related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open BB terminal fails to start on Mac M1
2 participants