Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2050 #2056

Merged
merged 3 commits into from
Jul 7, 2022
Merged

Fixes #2050 #2056

merged 3 commits into from
Jul 7, 2022

Conversation

hjoaquim
Copy link
Contributor

@hjoaquim hjoaquim commented Jul 7, 2022 •
edited
Loading

Description

  • Summary of the change / bug fix: added a verification for windows, since win version of mktime cannot cope with dates before 1970
  • Link # issue, if applicable: [Bug] OverflowError: mktime argument out of range #2050
  • Screenshot of the feature or the bug before/after fix, if applicable.
    Before
    image

After
image

  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
    Run command "load --ticker AMD --start 1900-01-01" on stocks
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@hjoaquim hjoaquim requested a review from Chavithra July 7, 2022 10:05
@hjoaquim hjoaquim changed the title Fixes 2050 Fixes #2050 Jul 7, 2022
@hjoaquim hjoaquim added the bug Fix bug label Jul 7, 2022
@hjoaquim hjoaquim linked an issue Jul 7, 2022 that may be closed by this pull request
[Bug] OverflowError: mktime argument out of range #2050
Closed
@hjoaquim hjoaquim merged commit 583d163 into OpenBB-finance:main Jul 7, 2022
@hjoaquim hjoaquim deleted the bug-2050 branch July 7, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DidierRLopes DidierRLopes DidierRLopes approved these changes

@Chavithra Chavithra Awaiting requested review from Chavithra

Assignees
No one assigned
Labels
bug Fix bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] OverflowError: mktime argument out of range
3 participants
@hjoaquim @DidierRLopes @Chavithra