-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements within the Terminal for the Documentation #2048
Improvements within the Terminal for the Documentation #2048
Conversation
One thing we have to check is whether |
My first thought is can we leave update for people who aren't using the installer? |
We saw people frequently messing this up that did have the installer. Is this really something people are using actively? To me, especially if you went through the whole installation process, it is just as easily done with |
That's why I was saying for people who are not using the installer. If you check the logs and update is not being successfully used either (from people who are using python) then I think we should drop it. But let's make sure is not being used first. |
Oh yeah that's fine but is it relatively easy to disable it for people using the installer? |
@piiq mentioned that there is a flag for it. |
We can print the download link to ppl who are using the installer when they call the update command. Will that work? @JerBouma @DidierRLopes |
That sounds fine, what's the flag for it? Then I can add it back in. @piiq @DidierRLopes |
…penBBTerminal into argparse_improvements
Ok fixed, care to review @DidierRLopes? This is with
|
I would avoid this part of the output |
Agreed with @piiq |
Makes sense, will adjust tomorrow. |
@DidierRLopes Should be all good now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great, love this
A small request I have is: Can you add a new line after the user utilises "about"?
- And in here you can see that it says that you can do stuff like "about exit" which shouldn't be the case, can we change the code so that is not an option.
- In addition, can we remove that last line about the "about about".
- Can we change banner to:
[about (cmd/menu)] Stocks (cmd/menu) Documentation
@DidierRLopes Here you go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super, thank you!
This PR features a bunch of things:
about
command now directs to the documentation and is dynamic. If you open thestocks
page it will direct to that page. It also allows you to enter a command or menu that is on the page. E.g. fromstocks
you can typeabout th
to go to the Trading Hours documentation.about
actually works. This requires URL changes on the website. This now aligns with the commands that are visible within the terminal. This should have been a 1-to-1 relationship in the first place.common
menu viaabout
update
command so users who are using the packaged version do not get some weird error.keys
menu to work well withabout
and update the text attached to it. It should now be clear that by typingabout
you get send to https://openbb-finance.github.io/OpenBBTerminal/#accessing-other-sources-of-data-via-api-keys