-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Economic calendar command #2043
Conversation
action="store", | ||
dest="time_zone", | ||
nargs="+", | ||
default=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the default timezone, we could fetch users' timezone in the settings and populate it dynamically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that makes sense
Very nice feature! 🚀 Calendar events can give some useful signals on how the economy is doing.
|
dest="categories", | ||
nargs="+", | ||
default=None, | ||
help="Event category.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@montezdesousa yes that's what I mean. And we can set a default |
Description
This PR adds an economic calendar to the economy menu. The command (ecocal) output is a rich table with information regarding world economic events. The database can be sliced by date, event category, event importance, country and set a GMT time zone. User can get actual, forecast and previous data point for each event (when applicable). Historic data is available as well.
Still have to write tests but would be nice to get some feedback first, particularly on usage and defaults. I believe this data might be useful later on automated reports for e.g. It is quite relevant for any investor or economic researcher that tracks on advanced indicators and arguably accounts for a relevant part of daily market movements.
Examples (after changes):
Lisbon time
New York time
How has this been tested?
Checklist:
Others
pre-commit install
.pytest tests/...
.