Fix trading hours bringing ticker in #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerBouma
reviewed
Jul 4, 2022
There was a problem hiding this comment.
Something off?
2022 Jul 04, 03:25 (🦋) /stocks/ $ th
Error: local variable 'result' referenced before assignment
Error: 'builtin_function_or_method' object has no attribute 'values'
2022 Jul 04, 03:25 (🦋) /stocks/ $
Maybe due to market closed?
2022 Jul 04, 03:25 (🦋) /stocks/ $ load TSLA
Loading Daily TSLA stock with starting period 2019-07-01 for analysis.
Datetime: 2022 Jul 04 03:25
Timezone: America/New_York
Currency: USD
Market: CLOSED
Company: Tesla, Inc.
TSLA Performance
┏━━━━━━━━━┳━━━━━━━━━┳━━━━━━━━━┳━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ 1 Day ┃ 1 Week ┃ 1 Month ┃ 1 Year ┃ YTD ┃ Volatility (1Y) ┃ Volume (10D avg) ┃ Last Price ┃
┡━━━━━━━━━╇━━━━━━━━━╇━━━━━━━━━╇━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ -0.54 % │ -7.51 % │ -7.91 % │ 0.57 % │ -43.17 % │ 74.49 % │ 33.5 M │ 681.79 │
└─────────┴─────────┴─────────┴────────┴──────────┴─────────────────┴──────────────────┴────────────┘
2022 Jul 04, 03:25 (🦋) /stocks/ $ th
Error: local variable 'result' referenced before assignment
Error: 'builtin_function_or_method' object has no attribute 'values'
2022 Jul 04, 03:25 (🦋) /stocks/ $
|
@JerBouma there were some conditions that were unaccounted for. Glad you tested it when you did because on the weekend this didn't occu
|
JerBouma
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1834