-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new portfolio metrics #2029
Adding new portfolio metrics #2029
Conversation
Makes pa actice and adds country to the df. The groupby command also gets percents of holding allocation. It also fixes warnings and prepares for a later pr that I'm currently working on.
black linter
…nkTerminal into portfolio_metrics
Hey @northern-64bit, What I am really missing is a simple Excel or Google Spreadsheet (or other tool) that illustrates that the calculations are correct. E.g. we need to be able to check whether the calculation makes logical sense to us. I think I could just let this PR go through but it would be very high-level look at whether the calculations match that of what I wrote down. You think you can find a way to see if your calculations are correct? E.g. create a very simple portfolio and show that it works. |
Sure, I'll make a simple portfolio in order to make a manual check with google sheets and then share it with you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this for now but we should re-check the metrics after portfolio refractor.
This is ready to be merged now after the tests have been fixed. |
Description
Added new portfolio metrics to the metric command. These metrics are:
"gaintopain",
"trackerr",
"information",
"tail",
"commonsense",
"jensens",
"calmar",
"kelly",
"payoff",
"profitfactor"
To do:
If anyone knows how to fix the commit log please message me.
How has this been tested?
I ran all of the new metrics commands in the terminal and they seemed to work. Could someone please validate that they are correctly calculated?
Checklist:
Others
pre-commit install
.pytest tests/...
.