Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2018 and updates default dates in dd_controller.py #2028

Merged
merged 3 commits into from
Jul 2, 2022

Conversation

soggyomelette
Copy link
Contributor

@soggyomelette soggyomelette commented Jul 1, 2022

Description

Fixes labels in #2018 and updates default dates for plots to from 2 years ago to 1 year ago (wherever the free glassnode api only allows fetching data with a 1y lag)

Before:
image

After:
image

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@Chavithra Chavithra added the bug Fix bug label Jul 1, 2022
@DidierRLopes DidierRLopes merged commit 45f0a0a into OpenBB-finance:main Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants