-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a test for binance key as asked for in #2006 #2026
Conversation
I also see that there are a few other keys that don't have tests written for them, is that something I could add to a TODO list? |
Hi @soggyomelette , yes please! |
You just need to run |
Great, I'll start working on it! |
Thank you @soggyomelette ❤️ |
Description
Adds a test for the binance key in the keys menu as there initially wasn't one present
Before:
After with incorrect key:
After with correct key:
How has this been tested?
Checklist:
Others
pre-commit install
.pytest tests/...
.