Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a test for binance key as asked for in #2006 #2026

Merged
merged 12 commits into from
Jul 2, 2022

Conversation

soggyomelette
Copy link
Contributor

@soggyomelette soggyomelette commented Jul 1, 2022

Description

Adds a test for the binance key in the keys menu as there initially wasn't one present

Before:
image

After with incorrect key:
image

After with correct key:
image

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes: Ran with incorrect keys and with my own keys to reproduce above results
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@soggyomelette
Copy link
Contributor Author

I also see that there are a few other keys that don't have tests written for them, is that something I could add to a TODO list?

@DidierRLopes DidierRLopes added the bug Fix bug label Jul 1, 2022
@DidierRLopes
Copy link
Collaborator

I also see that there are a few other keys that don't have tests written for them, is that something I could add to a TODO list?

Hi @soggyomelette , yes please!

@DidierRLopes
Copy link
Collaborator

You just need to run black file_changed_path and then we can merge this 😄

@soggyomelette
Copy link
Contributor Author

I also see that there are a few other keys that don't have tests written for them, is that something I could add to a TODO list?

Hi @soggyomelette , yes please!

Great, I'll start working on it!

@DidierRLopes DidierRLopes merged commit 7849b56 into OpenBB-finance:main Jul 2, 2022
@DidierRLopes
Copy link
Collaborator

Thank you @soggyomelette ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants