Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding integration tests to intel mac workflow #2020

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Adding integration tests to intel mac workflow #2020

merged 1 commit into from
Jul 1, 2022

Conversation

simmonsj330
Copy link
Contributor

@simmonsj330 simmonsj330 commented Jun 30, 2022 •
edited
Loading

Description

Changed workflow to be workflow_dispatch and added integration tests.

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@simmonsj330 simmonsj330 added the build Build-related work label Jun 30, 2022
@simmonsj330 simmonsj330 self-assigned this Jun 30, 2022
Chavithra
Chavithra approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me !
Let's see how it behaves on manual action trigger.

@DidierRLopes DidierRLopes merged commit 951c94d into OpenBB-finance:main Jul 1, 2022
@simmonsj330 simmonsj330 deleted the intel_mac_integration_tests_workflow branch July 7, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chavithra Chavithra Chavithra approved these changes

@piiq piiq Awaiting requested review from piiq

Assignees

@simmonsj330 simmonsj330

Labels
build Build-related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simmonsj330 @Chavithra @DidierRLopes