Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in a new GIF that better demonstrates the terminal #2010

Merged
merged 5 commits into from
Jun 29, 2022
Merged

Add in a new GIF that better demonstrates the terminal #2010

merged 5 commits into from
Jun 29, 2022

Conversation

JerBouma
Copy link
Contributor

@JerBouma JerBouma commented Jun 29, 2022

The point of the new one is:

  • It's faster (x2) making it easier for users to see everything that is available.
  • It shows more functionalities. It does skip Crypto though but the previous one also had limited options over there! @minhhoang1023, might need to re-do if you got some suggestions from commands that look interesting in a GIF? Preferences?
  • It is completely up to date with the latest release.

Added this one since it's also going to be in the presentation for Open Source Finance Forum 2022.

GIF

Also did some misc fixes:

  • README of installation on GitHub was outdated with broken links
  • Refreshed the "First step is to star" image

@JerBouma JerBouma added the docs Code documentation label Jun 29, 2022
@JerBouma JerBouma marked this pull request as ready for review June 29, 2022 10:08
@DidierRLopes DidierRLopes merged commit 8324f73 into OpenBB-finance:main Jun 29, 2022
@JerBouma JerBouma deleted the new_gif branch June 29, 2022 11:14
@piiq
Copy link
Contributor

piiq commented Jun 29, 2022

@JerBouma @DidierRLopes guys, can you please-please-please stop committing 33 megabyte binaries into the repo!

image

@JerBouma
Copy link
Contributor Author

JerBouma commented Jun 29, 2022

Hi Theo, I wanted to upload via GitHub itself but that didn't work, that is why. I feel like this GIF does add in a lot of understanding about the terminal when you visit our repository.

That said, maybe we need a separate repository where we dump in images/GIFs.

@DidierRLopes
Copy link
Collaborator

My bad on this, I didn't see the file being committed when scrolling through the code...

Now that is committed and will be on our git history, should we still remove it?

Also, can we add a test that checks if a PR adds more than xxx kB size and fails if yes?

@piiq
Copy link
Contributor

piiq commented Jun 29, 2022

it's there forever and ever and ever=)

yes, we should definitely add a test for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Code documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants