Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build workflow 1 #1999

Merged
merged 3 commits into from
Jun 29, 2022
Merged

Build workflow 1 #1999

merged 3 commits into from
Jun 29, 2022

Conversation

simmonsj330
Copy link
Contributor

@simmonsj330 simmonsj330 commented Jun 27, 2022 •
edited
Loading

Description

Creates workflow that builds openbb package. Saves .openbb folder, which can be used to extend the workflow to include integration tests. Currently set to run manually by clicking 'run workflow' until we decide later on when would be an appropriate time to trigger the workflow.

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@simmonsj330 simmonsj330 added the build Build-related work label Jun 27, 2022
@simmonsj330 simmonsj330 requested review from Chavithra and piiq June 27, 2022 22:12
@simmonsj330 simmonsj330 self-assigned this Jun 27, 2022
piiq
piiq previously requested changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@piiq piiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a single comment
💪🚀

.github/workflows/intel_macos_build.yml Show resolved Hide resolved
@simmonsj330 simmonsj330 requested a review from piiq June 28, 2022 18:11
Chavithra
Chavithra approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@simmonsj330 simmonsj330 dismissed piiq’s stale review June 29, 2022 16:57

Made the changes!

@simmonsj330 simmonsj330 merged commit 7cdd9ae into OpenBB-finance:main Jun 29, 2022
@simmonsj330 simmonsj330 deleted the build_workflow_1 branch July 7, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chavithra Chavithra Chavithra approved these changes

@piiq piiq Awaiting requested review from piiq

Assignees

@simmonsj330 simmonsj330

Labels
build Build-related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simmonsj330 @Chavithra @piiq