Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: crypto/headlines missing Legend & wrong Chart Title #1997

Merged
merged 12 commits into from
Jun 28, 2022

Conversation

soggyomelette
Copy link
Contributor

@soggyomelette soggyomelette commented Jun 27, 2022

Description

Changes markers to a more neutral colour to avoid confusion and fixes date shown in #1992
Before:
image

After:
image

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@DidierRLopes DidierRLopes added the enhancement Enhancement label Jun 27, 2022
@DidierRLopes
Copy link
Collaborator

Given that the "circles" are what is confusing, what do you think about removing them and just leaving the area on the back either red or blue for negative and positive respectively? @soggyomelette @minhhoang1023 thoughts?

@soggyomelette
Copy link
Contributor Author

Given that the "circles" are what is confusing, what do you think about removing them and just leaving the area on the back either red or blue for negative and positive respectively? @soggyomelette @minhhoang1023 thoughts?

Hey thanks for the suggestion! I think while it does remove the confusion it leaves a bit plain:
image

What do you think about having a more neutral colour like white as the marker?
image

@DidierRLopes DidierRLopes self-requested a review June 27, 2022 12:54
@DidierRLopes
Copy link
Collaborator

Yes @soggyomelette, I think it may be nicer the plain circles. Code would also be cleaner.

I have accepted the PR as this is an improvement regardless. So will let you decide 😄

@soggyomelette
Copy link
Contributor Author

Yes @soggyomelette, I think it may be nicer the plain circles. Code would also be cleaner.

I have accepted the PR as this is an improvement regardless. So will let you decide 😄

Haha thanks, the code is definitely a lot cleaner

@DidierRLopes
Copy link
Collaborator

Yes @soggyomelette, I think it may be nicer the plain circles. Code would also be cleaner.
I have accepted the PR as this is an improvement regardless. So will let you decide 😄

Haha thanks, the code is definitely a lot cleaner

Sweet, feel free to merge once the tests pass. Thank you 🙌🏽

@DidierRLopes DidierRLopes merged commit 1fe1f87 into OpenBB-finance:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants