-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: crypto/headlines missing Legend & wrong Chart Title #1997
Conversation
Given that the "circles" are what is confusing, what do you think about removing them and just leaving the area on the back either red or blue for negative and positive respectively? @soggyomelette @minhhoang1023 thoughts? |
Hey thanks for the suggestion! I think while it does remove the confusion it leaves a bit plain: What do you think about having a more neutral colour like white as the marker? |
Yes @soggyomelette, I think it may be nicer the plain circles. Code would also be cleaner. I have accepted the PR as this is an improvement regardless. So will let you decide 😄 |
Haha thanks, the code is definitely a lot cleaner |
Sweet, feel free to merge once the tests pass. Thank you 🙌🏽 |
Description
Changes markers to a more neutral colour to avoid confusion and fixes date shown in #1992
Before:
After:
How has this been tested?
Checklist:
Others
pre-commit install
.pytest tests/...
.